Version v0.3.4: Long TXs support, NVM storage, Settings submenu, fixes. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Show the message on the display directly, without a buffer * Use the maximum SRAM capacity for each Ledger model
* Create data types for the NVM storage. Initialize the NVM storage. * Create a settings step in the menu. ** Add the "Show Full Message" option. * Implement the ability to display a short message.
Codecov ReportBase: 63.83% // Head: 63.97% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #5 +/- ##
===========================================
+ Coverage 63.83% 63.97% +0.13%
===========================================
Files 13 13
Lines 777 780 +3
===========================================
+ Hits 496 499 +3
Misses 281 281
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+43
to
+52
| switch (idx) { | ||
| case MENU_SHOW_FULL_MSG: | ||
| ux_menulist_init_select(0, | ||
| show_full_message_getter, | ||
| show_full_message_selector, | ||
| N_storage.settings.show_full_message); | ||
| break; | ||
| default: | ||
| ui_menu_main(); | ||
| } |
Check notice
Code scanning / CodeQL
No trivial switch statements
There was a problem hiding this comment.
This is designed for the future, when more options are available.
tdejoigny-ledger
pushed a commit
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Features:
Fixes:
Changes include